PATCH: Add REINDEX tag to event triggers

From: Garrett Thornburg <film42(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: PATCH: Add REINDEX tag to event triggers
Date: 2023-07-21 04:47:00
Message-ID: CAEEqfk5bm32G7sbhzHbES9WejD8O8DCEOaLkxoBP7HNWxjPpvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Added my v1 patch to add REINDEX to event triggers.

I originally built this against pg15 but rebased to master for the patch
to hopefully make it easier for maintainers to merge. The rebase was
automatic so it should be easy to include into any recent version. I'd love
for this to land in pg16 if possible.

I added regression tests and they are passing. I also formatted the code
using the project tools. Docs are included too.

A few notes:
1. I tried to not touch the function parameters too much and opted to
create a convenience function that makes it easy to attach index or table
OIDs to the current event trigger list.
2. I made sure both concurrent and regular reindex of index, table,
database work as expected.
3. The ddl end command will make available all indexes that were modified
by the reindex command. This is a large list when you run "reindex
database" but works really well. I debated returning records of the table
or DB that were reindexed but that doesn't really make sense. Returning
each index fits my use case of building an audit record around the index
lifecycle (hence the motivation for the patch).

Thanks for your time,

Garrett Thornburg

Attachment Content-Type Size
v1-0001-Add-REINDEX-tag-to-event-triggers.patch application/octet-stream 12.3 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-07-21 05:39:22 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication
Previous Message Andrey Lepikhov 2023-07-21 04:21:01 Re: POC: GROUP BY optimization