Re: Extensions not dumped when --schema is used

Le sam. 20 févr. 2021 à 17:31, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> a écrit :

> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > As presented in this patch, specifying both --extension and
> > --table/--schema means that pg_dump will dump both tables and
> > extensions matching the pattern passed down. But shouldn't extensions
> > not be dumped if --table or --schema is used? Combining --schema with
> > --table implies that the schema part is ignored, for instance.
>
> I haven't read the patch, but the behavior I would expect is:
>
> 1. If --extension=pattern is given, then extensions matching the
> pattern are included in the dump, regardless of other switches.
> (Conversely, use of --extension doesn't affect choices about what
> other objects are dumped.)
>
> 2. Without --extension, the behavior is backward compatible,
> ie, dump extensions in an include_everything dump but not
> otherwise.
>
>
Yes, that's what it's supposed to do.

Maybe we could have a separate discussion as to which switches turn
> off include_everything, but that seems independent of this patch.
>
>
+1

--
Guillaume.