From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Extensions not dumped when --schema is used |
Date: | 2021-03-31 06:14:43 |
Message-ID: | CAECtzeXG_6CfUMA7=T2KxDmnecRu5Y-a6nt4BkrWyyCD2Uz7fQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Le mer. 31 mars 2021 à 02:37, Michael Paquier <michael(at)paquier(dot)xyz> a
écrit :
> On Tue, Mar 30, 2021 at 12:02:45PM +0900, Michael Paquier wrote:
> > Okay. So I have looked at that stuff in details, and after fixing
> > all the issues reported upthread in the code, docs and tests I am
> > finishing with the attached. The tests have been moved out of
> > src/bin/pg_dump/ to src/test/modules/test_pg_dump/, and include both
> > positive and negative tests (used the trick with plpgsql for the
> > latter to avoid the dump of the extension test_pg_dump or any data
> > related to it).
>
> I have double-checked this stuff this morning, and did not notice any
> issues. So, applied.
>
Thanks a lot. I've seen your email yesterday but had too much work going on
to find the time to test your patch. Anyway, I'll take a look at how you
coded the TAP test to better understand that part and to be able to do it
myself next time.
Thanks again.
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2021-03-31 06:16:12 | Re: Get memory contexts of an arbitrary backend process |
Previous Message | Tom Lane | 2021-03-31 06:14:06 | Re: making update/delete of inheritance trees scale better |