Re: Bad string from the translation point of view

2014-11-29 4:46 GMT+01:00 Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>:

>
> On 29 Nov 2014 03:09, "Guillaume Lelarge" <guillaume(at)lelarge(dot)info> wrote:
> >
> > 2014-11-28 15:13 GMT+01:00 Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>:
> >>
> >> On Fri, Nov 28, 2014 at 3:48 AM, Marek Černocký <marek(at)manet(dot)cz> wrote:
> >>>
> >>> The construction:
> >>>
> >>> if (wxMessageBox(_("Are you sure you wish to move objects from ") +
> >>> GetQuotedFullIdentifier() + _(" to ") + rdo.GetTablespace() + _("?"),
> >>> _("Move tablespace?"), wxYES_NO) != wxYES)
> >>> return;
> >>>
> >>> in pgadmin/schema/pgTablespace.cpp is bad from the point of view of
> >>> translation. It should be:
> >>>
> >>> if (wxMessageBox(wxString::Format(_("Are you sure you wish to move
> >>> objects from %s to %s?"), GetQuotedFullIdentifier(),
> >>> rdo.GetTablespace()), _("Move tablespace?"), wxYES_NO) != wxYES)
> >>> return;
> >>
> >> Agree.
> >>
> >> Dave,
> >>
> >> Can we consider this as bug?
> >>
> >
> > If you mean for 1.18, no. But 1.20, sure.
> I meant for 1.20 only. :)

If it's 1.20 only, I'd say "go ahead". There's no point delaying this.

--
Guillaume.
http://blog.guillaume.lelarge.info
http://www.dalibo.com