| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, mail(at)bwe(dot)im, PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Subject: | Re: BUG #12379: pgbench should hint to pgbench -i |
| Date: | 2015-07-05 16:34:27 |
| Message-ID: | CAECtzeVxR3zDJAcnzYrGu+ykUbU8DiY7w9_-TDToFY0ZSmOo-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Le 5 juil. 2015 6:28 PM, "Fabien COELHO" <coelho(at)cri(dot)ensmp(dot)fr> a écrit :
>
>
> Hello Guillaume & Julien,
>
> Thanks for the comments and the improvements!
>
>>> I can't look at the code right now, but doesn't it use PQdb() to get the
>>> name of the database? If it doesn't, it probably should.
>>
>>
>> I'm attaching a new version of the patch, which retrieves the actual
>> database name once connected if needed. That only solves this message
>> though, the other ones being displayed before the connection is
available.
>
>
> I'm not sure it is worth bothering with setting dbname which seems not to
be used afterwards anyway. I would suggest to coldly call PQdb on the
connection for the error message and thus simplify the code, as attached.
>
That's fine with me.
--
Guillaume
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2015-07-05 16:47:42 | Re: BUG #12379: pgbench should hint to pgbench -i |
| Previous Message | Fabien COELHO | 2015-07-05 16:28:22 | Re: BUG #12379: pgbench should hint to pgbench -i |