Re: Proposal: adding a better description in psql command about large objects

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Thibaud W(dot)" <thibaud(dot)walkowiak(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Proposal: adding a better description in psql command about large objects
Date: 2022-06-05 07:03:47
Message-ID: CAECtzeUJK4rZnnuxcjCSM2rCn=16yifBExguaYaWgqbN=yqpHw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le ven. 3 juin 2022 à 19:29, Nathan Bossart <nathandbossart(at)gmail(dot)com> a
écrit :

> On Fri, Jun 03, 2022 at 12:56:20PM -0400, Tom Lane wrote:
> > Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> >> Another option could be to move it after the "Input/Output" section so
> that
> >> it's closer to some other commands that involve files. I can't say I
> have
> >> a strong opinion about whether/where to move it, though.
> >
> > Yeah, I thought of that choice too, but it ends up placing the
> > Large Objects section higher up the list than seems warranted on
> > frequency-of-use grounds.
>
> Fair point.
>
> > After looking at the output I concluded that we'd be better off to
> > stick with the normal indentation amount, and break the lo_import
> > entry into two lines to make that work. One reason for this is
> > that some translators might've already settled on a different
> > indentation amount in order to cope with translated parameter names,
> > and deviating from the normal here will just complicate their lives.
> > So that leaves me proposing v5.
>
> I see. As you noted earlier, moving the entries higher makes the
> inconsistent indentation less appealing, too. So this LGTM.
>
>
Sounds good to me too.

Thanks.

--
Guillaume.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-06-05 09:19:33 Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch
Previous Message Justin Pryzby 2022-06-05 01:42:33 Re: should check interrupts in BuildRelationExtStatistics ?