From: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com> |
---|---|
To: | MauMau <maumau307(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [bug fix or improvement?] Correctly place DLLs for ECPG apps in bin folder |
Date: | 2014-07-08 21:38:12 |
Message-ID: | CAEB4t-OaX-CFoy5ka2TZ9t47usdZYtsrafB7nBCXLNv9J+buNw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Yes. Can you please take a look at Win_lib_bin.patch I shared earlier ?, I
think it is or similar approach will be appropriate. Thanks.
Regards,
Muhammad Asif Naeem
On Tue, Jul 8, 2014 at 5:53 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
> From: "Asif Naeem" <anaeem(dot)it(at)gmail(dot)com>
>
> Other than my pervious comments, patch looks good to me. Thanks.
>>
>
> Thanks for reviewing. I understood that your previous comment was to
> suggest copying the desired DLLs directly from Release/Debug folder to bin.
> But I'm afraid it cannot be done cleanly... CopySolutionOutput() copies
> all DLLS to lib folder with no exception as follows:
>
> if ($1 == 1)
> {
> $dir = "bin";
> $ext = "exe";
> }
> elsif ($1 == 2)
> {
> $dir = "lib";
> $ext = "dll";
> }
>
> It seems like I have to do something like this, listing the relevant DLL
> names anyway. I don't think this is not cleaner.
>
> if ($1 == 1)
> {
> $dir = "bin";
> $ext = "exe";
> }
> elsif ($1 == 2 && /* the project is libpq, libecpg, etc. */)
> {
> $dir = "bin";
> $ext = "dll";
> }
> elsif ($1 == 2)
> {
> $dir = "lib";
> $ext = "dll";
> }
>
> What do you think? Am I misunderstanding your suggestion?
>
> Regards
> MauMau
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-07-08 21:40:00 | Re: LEFT JOINs not optimized away when not needed |
Previous Message | Tom Lane | 2014-07-08 21:27:22 | Re: Allowing join removals for more join types |