Re: [PATCH] Add use of asprintf()

From: Asif Naeem <anaeem(dot)it(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add use of asprintf()
Date: 2013-10-02 09:12:58
Message-ID: CAEB4t-N+8j93PF_gRgB-mBTAJv1RSqru_POdbHLGRD5Hdmh6Zg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you Peter.
When I try to apply the patch on latest PG source code on master branch, it
gives the following error message i.e.

> asif$ git apply /Users/asif/core/Patch\:\ Add\ use\ of\
> asprintf\(\)/v2-0001-Add-use-of-asprintf.patch
> /Users/asif/core/Patch: Add use of
> asprintf()/v2-0001-Add-use-of-asprintf.patch:76: trailing whitespace.
> /Users/asif/core/Patch: Add use of
> asprintf()/v2-0001-Add-use-of-asprintf.patch:77: trailing whitespace.
> for ac_func in asprintf crypt fls getopt getrusage inet_aton random rint
> srandom strerror strlcat strlcpy
> /Users/asif/core/Patch: Add use of
> asprintf()/v2-0001-Add-use-of-asprintf.patch:90: trailing whitespace.
> AC_REPLACE_FUNCS([asprintf crypt fls getopt getrusage inet_aton random
> rint srandom strerror strlcat strlcpy])
> /Users/asif/core/Patch: Add use of
> asprintf()/v2-0001-Add-use-of-asprintf.patch:104: trailing whitespace.
> values[1] = psprintf("%s/%s", fctx->location, de->d_name);
> /Users/asif/core/Patch: Add use of
> asprintf()/v2-0001-Add-use-of-asprintf.patch:118: trailing whitespace.
> pg_asprintf(&todo,
> fatal: git apply: bad git-diff - expected /dev/null on line 1557

Neither git nor patch command apply the patch successfully. Can you please
guide ?. Thanks.

Best Regards,
Muhammad Asif Naeem

On Wed, Oct 2, 2013 at 7:29 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote:
> > I did put some time review the patch, please see my findings below
> > i.e.
>
> Updated patch for this.
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-10-02 09:18:25 Re: review: psql and pset without any arguments
Previous Message Tatsuo Ishii 2013-10-02 08:40:00 Re: [HACKERS] Who is pgFoundery administrator?