Re: test_session_hooks--1.0.sql file in 'test_session_hooks' needs correction

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: test_session_hooks--1.0.sql file in 'test_session_hooks' needs correction
Date: 2017-11-16 14:12:45
Message-ID: CAE9k0PnEaPkfe64N1Gx+FvJ1WrKg-_TNc=BcHW-AKBJMwcyN=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 16, 2017 at 6:47 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:

> On Thu, Nov 16, 2017 at 7:49 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
> wrote:
> > The test_session_hooks--1.0.sql file in the newly added
> 'test_session_hooks'
> > module suggests to load the extension named 'test_hook_session' instead
> of
> > 'test_session_hooks' and i think it needs to be corrected. Here are the
> > contents available in test_session_hooks--1.0.sql file.
> >
> >
> > -- complain if script is sourced in psql, rather than via CREATE
> EXTENSION
> > \echo Use "CREATE EXTENSION test_hook_session" to load this file. \quit
>
> The sql file, the control file, and the definitions of DATA and
> EXTENSION in the Makefile could just be deleted.
>

Oh Yes, I just saw your latest patch that you shared an hour before. You
have removed the control file and test_hook_session--1.0.sql files. So, my
complaint is no more valid. Thanks.

> --
> Michael
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2017-11-16 14:14:52 Re: pgsql: Disable installcheck tests for test_session_hooks
Previous Message Merlin Moncure 2017-11-16 14:00:14 Re: [HACKERS] Transaction control in procedures