Utilisation of get_page_from_raw() in pageinspect

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Utilisation of get_page_from_raw() in pageinspect
Date: 2018-06-27 09:01:12
Message-ID: CAE9k0Pn-af1AyKTLb3XTb-JCV24Ucs7FEGYmhj=yfHrxeFvyog@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi All,

Currently, get_page_from_raw() is not used in the pageinspect
functions for btree and heap to fetch a page image from raw page.
However, the pageinspect for gin and hash is using it to avoid server
crash on alignment picky machines with MAXALIGN = 8. Shouldn't we
start using it in the pageinspect functions for btree and heap as well
for safety purpose. Thoughts?

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-06-27 09:12:18 Re: postgresql_fdw doesn't handle defaults correctly
Previous Message Yugo Nagata 2018-06-27 08:52:53 Re: Small fixes about backup history file in doc and pg_standby