| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WAL Consistency checking for hash indexes |
| Date: | 2017-03-17 07:00:19 |
| Message-ID: | CAE9k0PmiO=1UTJCEL_FKgRsRJEkGmPxC5S7V2SYVhBC0Vyi2hw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 17, 2017 at 9:03 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Mar 16, 2017 at 1:15 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>> Hi,
>>
>> Attached is the patch that allows WAL consistency tool to mask
>> 'LH_PAGE_HAS_DEAD_TUPLES' flag in hash index. The flag got added as a
>> part of 'Microvacuum support for Hash index' patch . I have already
>> tested it using Kuntal's WAL consistency tool and it works fine.
>>
>
> + * unlogged. So, mask it. See _hash_kill_items(), MarkBufferDirtyHint()
> + * for
> details.
> + */
>
> I think in above comment, a reference to _hash_kill_items is
> sufficient. Other than that patch looks okay.
Okay, I have removed the reference to MarkBufferDirtyHint() from above
comment. Attached is the v2 version of patch.
--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Allow-WAL-consistency-tool-to-mask-LH_PAGE_HAS_DEAD_.patch | binary/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Sontakke | 2017-03-17 07:39:16 | Re: Speedup twophase transactions |
| Previous Message | Ashutosh Sharma | 2017-03-17 06:57:17 | Re: Microvacuum support for Hash Index |