| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | david(dot)rowley(at)2ndquadrant(dot)com |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Multi-insert into a partitioned table with before insert row trigger causes server crash on latest HEAD |
| Date: | 2018-10-20 15:03:22 |
| Message-ID: | CAE9k0Pm2B6vPf2rXOpys2sxZ0ezVgowUeACzXFPQgjXR9VZ9Ag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Thanks for pushing that fix.
>
> Originally my patch in [1] only could set leafpart_use_multi_insert to
> true within the `if (insertMethod == CIM_MULTI_CONDITIONAL)` test, so
> wouldn't have suffered from this problem.
>
The problem is reproducible even with the patch in [1] combined with
the v6 edition of delta patch. Actually this problem has nothing to do
with where we set leafpart_use_multi_insert flag. It's about using the
right values (updated values) to decide if the current partition is
good to go for multi-insert or not. Like i mentioned earlier reply,
we actually came across this problem because we have used outdated
value for before insert row trigger to evaluate
leafpart_use_multi_insert flag.
--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2018-10-20 16:06:56 | Re: gemulon migration upcoming |
| Previous Message | Stefan Kaltenbrunner | 2018-10-20 14:48:57 | gemulon migration upcoming |