Re: ICU support on Windows

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: ICU support on Windows
Date: 2017-06-12 18:17:00
Message-ID: CAE9k0PkwTusviPrwA8haWeTU-4f8T9RhYK+BJxkdTpTDGk+VPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Jun 12, 2017 11:43 PM, "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com> wrote:

Ashutosh Sharma wrote:
> > I noticed that this only works if you use the "Win32" download of ICU,
> > because the "Win64" download uses "lib64" paths. I'm not sure what the
> > impact of this is in practice.
>
> Yes, that's right, Win64 download uses lib64 path and in my case i had
> renamed lib64-> lib and bin64-> bin which i guess is not a right thing
> to do. I think, we should allow Solution.pm to detect the platform and
> make a decision on the library path accordingly. Attached patch does
> that. Please have a look let me know your thoughts on this. Thanks.

Uh, that's pretty odd. Is it something libicu-specific? Because I
don't see any other occurrence of \lib64\ anywhere in the MSVC build
scripts.

Yes, it is specific to libicu.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2017-06-12 18:33:49 Re: PG10 Partitioned tables and relation_is_updatable()
Previous Message Alvaro Herrera 2017-06-12 18:13:50 Re: ICU support on Windows