Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: orafce: some of the build time generated files are not present in .gitignore and also checked into the repository
Date: 2022-04-26 13:04:54
Message-ID: CAE9k0PkXGOn2NG9wVjJ64sq+qwsFEkBzAJNM+q52OTcB7Hk_KQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sure, I'll do that.

Thanks,
Ashutosh

On Tue, Apr 26, 2022 at 5:51 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 26 Apr 2022, at 14:19, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>
> > The below files in orafce contrib module are generated at build time.
> > However, these are checked into the repository. Shouldn't these files
> > be removed from the repository and added to the .gitignore file so
> > that they get ignored in the future commits.
>
> You should probably take this to the orafce project instead, possibly with a PR
> against their repo?
>
> --
> Daniel Gustafsson https://vmware.com/
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-04-26 13:15:24 Re: Cryptohash OpenSSL error queue in FIPS enabled builds
Previous Message Ashutosh Sharma 2022-04-26 12:58:23 Re: double inclusion of '-p' flex flag