#include <stdlib.h> present twice in define.pgc

From: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>
To: pgsql-interfaces(at)postgresql(dot)org
Cc: Michael Meskes <meskes(at)postgresql(dot)org>
Subject: #include <stdlib.h> present twice in define.pgc
Date: 2020-09-07 13:47:58
Message-ID: CAE9k0PkORqHHGKY54-sFyDpP90yAf+05Auc4fs9EAn4J+uBeUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces

Hi All,

I could see that the #include <stdlib.h> statement is present twice in the
define.pgc test file. See below:

[ashu(at)localhost postgresql]$ head
src/interfaces/ecpg/test/preproc/define.pgc
#include <stdlib.h>
#include <string.h>
#include <stdlib.h>
#include <stdio.h>

exec sql include ../regression;

...
...

Should we consider removing one of them?

I know that there won't be multiple inclusion of the same header file
because of #ifndef and #define pre-processor directives which defines
_STDLIB_H macro that allows the file to included just once, but I still
feel that it is better to avoid having such things. It doesn't do any harm
but is certainly not required. Thoughts?

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com

Responses

Browse pgsql-interfaces by date

  From Date Subject
Next Message Blum, Kimber 2020-12-09 21:29:03 Issue with mysql_fdw
Previous Message Ashutosh Sharma 2020-08-31 12:53:51 ecpg: the comments inside the declare section are not outputted correctly.