| From: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect: Hash index support |
| Date: | 2017-02-03 04:00:25 |
| Message-ID: | CAE9k0P=uYJV+3UZoA3opsgU_g7ENL63_0uTmCUyefhDAPBFbvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> I think it's OK to check hash_bitmap_info() or any other functions
>> with different page types at least once.
>>
>> [1]- https://www.postgresql.org/message-id/CA%2BTgmoZUjrVy52TUU3b_Q5L6jcrt7w5R4qFwMXdeCuKQBmYWqQ%40mail.gmail.com
>
> Sure, I just don't know if we need to test them 4 or 5 times. But I
> think this is good enough for now - it's not like this code is written
> in stone once committed.
>
> So, committed. Wow, I wish every patch had this many reviewers.
>
Thanks Robert and Thank you to all the experts for showing their
interest towards this project.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-03 04:03:21 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Previous Message | Tom Lane | 2017-02-03 04:00:19 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |