| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2017-09-27 15:45:04 |
| Message-ID: | CAE2gYzz1KuT57vrO-XZk3KSqdpehAupJPLYu7AshuUwRF7MiMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> The patch replace pg_hypot with hypot in libc. The man page says
> as follows.
>
> man 3 hypot
>> If the result overflows, a range error occurs, and the functions return
>> HUGE_VAL, HUGE_VALF, or HUGE_VALL, respectively.
> ..
>>ERRORS
>> See math_error(7) for information on how to determine whether an error
>> has occurred when calling these functions.
>>
>> The following errors can occur:
>>
>> Range error: result overflow
>> errno is set to ERANGE. An overflow floating-point exception
>> (FE_OVERFLOW) is raised.
>>
>> Range error: result underflow
>> An underflow floating-point exception (FE_UNDERFLOW) is raised.
>>
>> These functions do not set errno for this case.
>
> So, the code seems to need some amendments following to this
> spec.
I included them on the latest version.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-27 15:45:11 | Re: 200 = 199 + 1? |
| Previous Message | Emre Hasegeli | 2017-09-27 15:44:52 | Re: [PATCH] Improve geometric types |