From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se> |
Subject: | Re: Selectivity estimation for inet operators |
Date: | 2015-02-15 21:25:32 |
Message-ID: | CAE2gYzyqnu07EJdK6MXwimU0hw40KV4Os5=WbTGiVTmM+F4k-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
New version of the patch attached with the optimization to break the
loop before looking at all of the histogram values. I can reduce
join selectivity estimation runtime by reducing the values of the
left hand side or both of the sides, if there is interest.
> > Even if the above aspects of the code are really completely right, the
> > comments fail to explain why. I spent a lot of time on the comments,
> > but so far as these points are concerned they still only explain what
> > is being done and not why it's a useful calculation to make.
>
> I couldn't write better comments because I don't have strong arguments
> about it. We can say that we don't try to make use of the both of
> the endpoints, because we don't know how to combine them. We only use
> the one with matching family and masklen, and when both of them match
> we use the distant one to be on the safer side.
I added two more sentences to explain the calculation.
Attachment | Content-Type | Size |
---|---|---|
inet-selfuncs-v14.patch | text/x-diff | 32.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2015-02-15 21:43:23 | Re: mogrify and indent features for jsonb |
Previous Message | Tomas Vondra | 2015-02-15 21:13:55 | Re: EXPERIMENTAL: mmap-based memory context / allocator |