From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: "pgoutput" options missing on documentation |
Date: | 2023-12-18 07:38:16 |
Message-ID: | CAE2gYzyprXTwH_-J3TMy06DhpKzgEz0aQnMThj=TVMztsaA5MQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> This change (Required in between two sentences) looks slightly odd to
> me. Can we instead extend the second line to something like: "This
> parameter is required, and the individual publication names are ...".
> Similarly we can adjust the proto_vesion explanation.
I don't think it's an improvement to join 2 independent sentences with
a comma. I expanded these by mentioning what is required.
> This sounds like we are supporting more than one logical decoding
> plugin. Can we slightly rephrase it to something like:
> "PostgreSQL</productname> supports extensible logical decoding plugin
> <literal>pgoutput</literal> which is used for the built-in logical
> replication as well."
I understand the confusion. I reworded it and dropped "extensible".
The new versions are attached.
Attachment | Content-Type | Size |
---|---|---|
v03-0002-doc-Clarify-pgoutput-options.patch | application/octet-stream | 8.6 KB |
v03-0001-pgoutput-Test-if-proto_version-is-given.patch | application/octet-stream | 3.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Hayato Kuroda (Fujitsu) | 2023-12-18 07:40:43 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
Previous Message | Emre Hasegeli | 2023-12-18 07:38:04 | Re: "pgoutput" options missing on documentation |