_isnan() on Windows

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: _isnan() on Windows
Date: 2018-07-10 17:36:39
Message-ID: CAE2gYzyc0+5uG+Cd9-BSL7NKC8LSHLNg1Aq2=8ubjnUwut4_iw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

isnan() function is evidently not present on <math.h> on Windows
before Visual Studio 2013. We define it on win32_port.h using
_isnan(). However _isnan() is also not present. It is on <float.h>.
The patch is attached to include this from win32_port.h.

Thanks to Thomas Munro for point this out to me [1]. It is hard to
notice this issue without testing the changes on Windows.

[1] https://www.postgresql.org/message-id/CAEepm%3D3dE0w%3D_dOcELpPum6suze2NZwc%3DAV4T_xYrDUoHbZJvA%40mail.gmail.com

Attachment Content-Type Size
win32_port_float_h_v00.patch application/octet-stream 11.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Emre Hasegeli 2018-07-10 17:36:41 Re: [PATCH] Improve geometric types
Previous Message Fujii Masao 2018-07-10 17:26:06 Re: [PATCH] Timestamp for a XLOG_BACKUP_END WAL-record