Re: [HACKERS] [PATCH] Improve geometric types

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Improve geometric types
Date: 2017-11-19 20:10:38
Message-ID: CAE2gYzyFdZaBi60iFm4X=skU-YG7GbgD7ZQKeyFV=GswtoVQTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> dist_pl is changed to take the smaller distance of both ends of
> the segment. It seems absorbing error, so it might be better
> taking the mean of the two distances. If you have a firm reason
> for the change, it is better to be written there, or it might be
> better left alone.

I am sorry for not paying enough attention to this before. The
distance functions are meant to return the minimum distance. Getting
the maximum is just wrong in here. Can you think of any particular
error it would absorb? Otherwise I will put this change back to the
patch for fixes.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jotpe 2017-11-19 20:17:46 Re: percentile value check can be slow
Previous Message Alik Khilazhev 2017-11-19 19:53:52 Re: [HACKERS] [WIP] Zipfian distribution in pgbench