Re: Line intersection point is wrong

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Line intersection point is wrong
Date: 2016-06-19 19:19:54
Message-ID: CAE2gYzxrfOaje7D6vWJvs0FnmFE4MEEcfyb=O6EDzgzC64GzxA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> Hmm, well, what if we change line_parallel() so that what it tests
> is whether (l1->A * l2->B - l2->A * l1->B) is zero? That seems
> simpler and more symmetric than what it does now.

I was thinking to do so. I would also check for both sides not to
overflow, but that can wait. Patch attached. Unfortunately,
the change causes too much noise on the regression tests.

Attachment Content-Type Size
fix-line-v1.patch text/x-diff 303.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2016-06-19 20:16:42 Re: Line intersection point is wrong
Previous Message Tom Lane 2016-06-19 18:51:59 Re: Line intersection point is wrong