| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2018-07-30 09:41:24 |
| Message-ID: | CAE2gYzxSLekocQhyRXsTk7jJs4DNbH217L-vGbdjUnaaFFaayw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> This should fix it I guess, and it's how we deal with unused return
> values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it
> seems rather ugly with that. I'll wait for Emre's opinion ...
Assert() is the wrong thing to do in here. Drawn-perpendicular lines
may not intersect because of precision loss. We have to check it and
return NULL. There a few of those that we crash, or return garbage,
or get NULL and fail in DirectFunctionCall()s. The next patch
"line-fixes" fixes them.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2018-07-30 09:48:13 | Re: patch to allow disable of WAL recycling |
| Previous Message | Amit Langote | 2018-07-30 09:21:54 | Re: partition tree inspection functions |