| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Redefining inet_net_ntop |
| Date: | 2018-01-26 10:07:52 |
| Message-ID: | CAE2gYzx9XENk2aiJ10RPZkCnoyrVZTcwKkcD2=pgwRZ5ZJUPSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> port.h declares inet_net_ntop and we always compile our own from
> port/inet_net_ntop.c .
There is another copy of it under backend/utils/adt/inet_cidr_ntop.c.
The code looks different but does 90% the same thing. Their naming
and usage is confusing.
I recently needed to format IP addresses as DNS PTR records in the
database, and got annoyed by having no functions that outputs IPv6
addresses in easily parseable format like
0000:0000:0000:0000:0000:0000:0000:0000. I was going to send a patch
to unify those C functions and add another SQL function to get
addresses in such format. Is this a good plan? Where should those C
functions be on the tree if they are not port of anything anymore?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tels | 2018-01-26 11:03:08 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Previous Message | Konstantin Knizhnik | 2018-01-26 10:06:27 | Re: JIT compiling with LLVM v9.0 |