From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
---|---|
To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Improve geometric types |
Date: | 2018-03-09 10:17:45 |
Message-ID: | CAE2gYzw7ee1A5C3AvajHoyvu4BaGae+iTJJ8=09t-LY0YKUHTA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Thank you for the revised version. This seems fine for me so
> marked this as "Ready for Committer".
Thank you for bearing with me for longer than year.
> By the way I think that line_perp is back patched, could you
> propose it for the older versions? (I already marked my entry as
> Rejected)
Do you mean back-patching?
> Brief summary follows (almost same to the header of patch files):
>
> - 0001 looks fine.
> > * Eliminate SQL level function calls
> > * Re-use more functions to implement others
> > * Unify internal function names and signatures
> > * Remove private functions from geo_decls.h
> > * Replace not-possible checks with Assert()
> > * Add comments to describe some functions
> > * Remove some unreachable code
> > * Define delimiter symbols of line datatype like the other ones
> > * Remove debugging print()s from the refactored functions
>
> And one bug fix.
What is that one? Should I incorporate it into the commit message?
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2018-03-09 10:51:09 | Re: [HACKERS] Partition-wise aggregation/grouping |
Previous Message | amul sul | 2018-03-09 09:48:43 | Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key |