Re: Changes to recovery_min_apply_delay are ignored while waiting for delay

From: Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, ashwinstar(at)gmail(dot)com
Subject: Re: Changes to recovery_min_apply_delay are ignored while waiting for delay
Date: 2021-08-03 07:06:34
Message-ID: CAE-ML+_st=dKvk8G7owfcK50gKDPn_iMme=GthYzN-xFG-WY5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Kyotaro,

Thanks for the review!

On Mon, Aug 2, 2021 at 11:42 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:

> One comment from me.
>
> +$node_standby->safe_psql('postgres', "ALTER SYSTEM SET recovery_min_apply_delay TO 0;");
>
> It might be better do "SET reco.. TO DEFAULT" instead.
>

Sure.

> And how about adding the new test at the end of existing tests. We can
> get rid of the extra lines in the diff.

No problem. See attached v2. I didn't do that initially as the test file
looks as though it is split into two halves: one for testing
recovery_min_apply_delay and the other for testing recovery pause. So while
making this change, I added a header comment for the newly added test case.
Please take a look.

Regards,
Soumyadeep (VMware)

Attachment Content-Type Size
v2-0001-Refresh-delayUntil-in-recovery-delay-loop.patch text/x-patch 4.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2021-08-03 07:40:22 RE: Parallel Inserts (WAS: [bug?] Missed parallel safety checks..)
Previous Message Amit Kapila 2021-08-03 07:02:31 Re: [HACKERS] logical decoding of two-phase transactions