| From: | Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch |
| Date: | 2019-09-28 06:01:05 |
| Message-ID: | CAE-ML+9_9EmKQgTzzypiXRk+1+XCm9mDs3o5wa0=8oEVmz_M=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hey,
I completely agree, that was an important consideration.
I had some purely cosmetic suggestions:
1. Rename ExecComputeSlotInfo to eliminate the need for the asserts.
2. Extract return value to a bool variable for slightly better
readability.
3. Taking the opportunity to use TTS_IS_VIRTUAL.
v2 of patch set attached. The first two patches are unchanged, the cosmetic
changes are part of v2-0003-Some-minor-cosmetic-changes.patch.
--
Soumyadeep
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Reduce-code-duplication-for-ExecJust-Var-operatio.patch | application/octet-stream | 6.9 KB |
| v2-0002-Don-t-generate-EEOP_-_FETCHSOME-operations-for-sl.patch | application/octet-stream | 11.3 KB |
| v2-0003-Some-minor-cosmetic-changes.patch | application/octet-stream | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-09-28 06:06:05 | Re: Change atoi to strtol in same place |
| Previous Message | Michael Paquier | 2019-09-28 06:00:35 | Re: contrib/bloom Valgrind error |