Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

From: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#2950] Add marker to dashboard queries
Date: 2018-02-15 14:33:06
Message-ID: CAE+jjanFb+Np3BqmPDzB80cHJzM4uEZNH2bge+0LS7Q+j6EczA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Murtuza,
I was looking into the Issue information and the solution that was provided
there needs some polish. With the solution that was asked, the log will
still be generated, but eventually will not show up in a log monitor, but
nevertheless will be there.

After some digging around the code I saw that we are using Logging Level 25
for all SQL queries what if we give 24 for the dashboard logs?
Another option, that I didn't look into very much was the possibility of
passing a logger into the execution functions or even somehow tag them so
we can have more control over the logs that we generate. It would be nice
if we could somehow ignore all the logs from the Dashboard. (
http://flask.pocoo.org/docs/dev/logging/#other-libraries)

What do you think about the suggestion?

Thanks
Joao

On Thu, Feb 15, 2018 at 8:51 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch to add marker in dashboard queries, it will allow to user to
> filter out those queries from database logs if required.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao De Almeida Pereira 2018-02-15 15:07:18 Re: [pgAdmin4][RM#3121] Fix PEP-8 issues
Previous Message Robert Eckhardt 2018-02-15 14:26:52 Next release