[patch] Column selection on SQLEditor

From: Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Atira Odhner <aodhner(at)pivotal(dot)io>
Subject: [patch] Column selection on SQLEditor
Date: 2017-03-14 22:08:47
Message-ID: CAE+jjamj4iYK4OSMxno5hcfTDS7j+6ZF+DqN3ggq49E3LpR9wg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached you can find the patches that finish the following Redmine Issue
https://redmine.postgresql.org/issues/2216

*Note:*
These changes depend on the acceptance of the patch that we submitted on
the email thread: "Refactor: clipboard, translations, jasmine"

This makes some changes and adds testing around the way csv is copied to
the clipboard.
We had to write a new plugin to handle selecting columns since slickGrid
does not care much about columns.

We also fixed a bug with the csv selection where strings were not being
quoted. (it was introduced recently.) Now there are jasmine tests around it.

--
Thanks
Joao & Tira

Attachment Content-Type Size
0001-Add-column-selector-to-SQLEditor.patch application/octet-stream 10.0 KB
0002-Refactor-copyData-Add-feature-test.patch application/octet-stream 12.9 KB
0003-Add-RangeBoundryNavigator.patch application/octet-stream 27.1 KB
0004-Deselect-rows-when-clicking-on-column-header.patch application/octet-stream 9.9 KB
0005-Update-README-with-missing-package-to-enable-testing.patch application/octet-stream 834 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Jonas Thelemann 2017-03-15 00:57:46 Re: pgAdmin 4 commit: Remove \n in translation that was causing a syntax er
Previous Message Atira Odhner 2017-03-14 20:16:37 Re: [patch] Refactor: clipboard, translations, jasmine