Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

@Dave I sent the new patch with correction in the previous email. Can you
review it and let us know if it is ok?

On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Thanks for the help Murtuza
>
> Attached you can find the revisited patch that now displayed all the
> information about functions in GreenPlum
>
> Thanks
> Joao
>
> On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> ​Hi,
>>
>> We ​create collection of existing parameters using function
>> 'def _format_arguments_from_db(...)' in a file
>> '../pgadmin4/web/pgadmin/browser/server_groups/servers/datab
>> ases/schemas/functions/__init__.py' @ line 454, and on client side we
>> have backbone collection mapped with same id on line 304 (function.js)
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <
>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>
>>> Hello,
>>> I changed that function to make the retrieval quicker because the return
>>> type of all the types in the database for GreenPlum can be quite big.
>>>
>>> Nevertheless the "Data Types" in the front end do not get filled up with
>>> the values.
>>>
>>> Where is the Javascript code that does the mapping between the call of
>>> get_types and that table in the screenshot?
>>>
>>> Thanks
>>> Joao
>>>
>>>
>>> On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Joao,
>>>>
>>>> We have written common function 'def get_types(...)' in a class called
>>>> 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/brows
>>>> er/server_groups/servers/databases/schemas/utils.py' and we have
>>>> inherited from DataTypeReader in Function module's 'FunctionView' class to
>>>> use it check line no. 120
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <
>>>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>>>
>>>>> Hello Hackers,
>>>>> We had some requests from GreenPlum users to display the functions
>>>>> node again.
>>>>> This patch reintroduces functions as a node underneath the Schemas.
>>>>>
>>>>>
>>>>> Unfortunately this patch is not final because I could not find the
>>>>> place where the Data Type is populated from. (See next image)[image:
>>>>> Inline image 1]
>>>>>
>>>>> Can anyone explain me how these types get populated?
>>>>>
>>>>>
>>>>>
>>>>> Thanks
>>>>> Joao
>>>>>
>>>>
>>>>
>>>
>>
>