Re: [pgAdmin4] [PATCH] History Tab rewrite in React

Okay

Can you try removing web/node_modules and web/yarn.lock, and running
$ yarn install
$ grunt tests

We think this might be due to a bad version of phantomjs-prebuilt.

If that still fails, can you try running grunt as "yarn run grunt tests"?

Joao and George

On Fri, May 19, 2017 at 10:27 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Thu, May 18, 2017 at 4:37 PM, Matthew Kleiman <mkleiman(at)pivotal(dot)io>
> wrote:
> > Dave,
> >
> > Can you try running grunt tests on the command line?
> >
> > The tests task will run the eslint and karma grunt tasks, which should
> > automatically webpack the React components before running the jasmine
> tests
> > in karma.
> >
> > If it still fails, send us the output of that.
>
> (pgadmin4)piranha:web dpage$ grunt tests
> Running "eslint:target" (eslint) task
>
> Running "karma:unit" (karma) task
> 19 05 2017 15:26:13.366:ERROR [plugin]: Error during loading
> "karma-phantomjs-launcher" plugin:
> Path must be a string. Received null
>
> webpack: Compiled successfully.
> webpack: Compiling...
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> (node:66274) DeprecationWarning: loaderUtils.parseQuery() received a
> non-string value which can be problematic, see
> https://github.com/webpack/loader-utils/issues/56
> parseQuery() will be replaced with getOptions() in the next major
> version of loader-utils.
> 19 05 2017 15:26:18.887:WARN [karma]: No captured browser, open
> http://localhost:9876/
>
> webpack: Compiled successfully.
> 19 05 2017 15:26:18.895:ERROR [karma]: Found 1 load error
> Warning: Task "karma:unit" failed. Use --force to continue.
>
> Aborted due to warnings.
>
>
> :-(
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>