| From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database. |
| Date: | 2018-06-04 19:38:25 |
| Message-ID: | CAE+jjakwbfsbwkvwa6N1QGjGeVb36sWnde+C6amnHQLHdTE3kQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hello Aditya,
>
>
> There is no change related to notifications in this patch.
> The below code is minor fix related to connection status of sql editor.
> Can you please share the code snippet if it is not the below.
>
> - # Check for the asynchronous notifies statements.
> - conn.check_notifies(True)
> - notifies = conn.get_notifies()
> + if status is not None:
> + # Check for the asynchronous notifies statements.
> + conn.check_notifies(True)
> + notifies = conn.get_notifies()
>
>
This is a minor fix, but is it related to querying SQL_ASCII database?
Thanks
Victoria && Joao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-06-04 21:27:21 | [pgadmin][patch] Electron version 4.X |
| Previous Message | Aditya Toshniwal | 2018-06-04 16:44:19 | Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database. |