Re: [pgAdmin4] [PATCH] History Tab rewrite in React

Hi Hackers!

Please find attached the two patches, now including a new grunt task to run
the tests only once that can be used in CI. For development, use grunt test,
for ci or to run tests only once, use grunt test-ci. This is documented in
the README file.

Also note, these patches were generated using git diff as per
https://www.pgadmin.org/docs/pgadmin4/dev/submitting_patches.html. Sorry
for any inconvenience from generating a patch in an alternate manner
earlier.

Thanks,
Joao & Matt

On Wed, May 24, 2017 at 9:36 AM, Matthew Kleiman <mkleiman(at)pivotal(dot)io>
wrote:

> Hi Dave,
>
> This one is our bad! We didn't create a grunt task to run the tests only
> once, as you would in CI. grunt tests currently runs the tests and
> continues to watch for changes, running the tests again each time the
> source code is modified. We will create a task that is suitable to run in
> CI.
>
> In the meantime, if you have any free time during the day today and would
> like to schedule a sync call with us, that would help us to tighten the
> feedback loop.
>
> Thanks,
> Joao & Matt
>
> On Tue, May 23, 2017 at 4:44 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Tue, May 23, 2017 at 12:12 PM, Joao Pedro De Almeida Pereira
>> <jdealmeidapereira(at)pivotal(dot)io> wrote:
>> > Okay
>> >
>> > Can you try removing web/node_modules and web/yarn.lock, and running
>> > $ yarn install
>> > $ grunt tests
>> >
>> > We think this might be due to a bad version of phantomjs-prebuilt.
>> >
>> > If that still fails, can you try running grunt as "yarn run grunt
>> tests"?
>>
>> I'm on a different machine now, and here grunt just seems to never
>> exit when it's doing anything. For example, I ran this a few minutes
>> ago, it finished in seconds and has been sitting here ever since:
>>
>> (pgadmin4)snake:web dpage$ grunt tests
>> Running "eslint:target" (eslint) task
>>
>> Running "karma:unit" (karma) task
>>
>> webpack: Compiled successfully.
>> webpack: Compiling...
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> webpack: wait until bundle finished:
>> (node:4902) DeprecationWarning: loaderUtils.parseQuery() received a
>> non-string value which can be problematic, see
>> https://github.com/webpack/loader-utils/issues/56
>> parseQuery() will be replaced with getOptions() in the next major
>> version of loader-utils.
>> 23 05 2017 16:41:54.549:WARN [karma]: No captured browser, open
>> http://localhost:9876/
>>
>> webpack: Compiled successfully.
>> PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 87 of 88 (skipped 1)
>> SUCCESS (1.353 secs / 1.328 secs)
>>
>> I'm quite unimpressed with it so far :-(
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>