| From: | Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Issue with SlickGrid |
| Date: | 2017-04-26 20:53:08 |
| Message-ID: | CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hello Hackers,
While doing some changes to the Query Results we found out that there was a
issue with Slick grid.
The issue that we found was with the CellSelectModel, behaved differently
when pressing Ctrl and Command(Mac). We created a PR
<https://github.com/6pac/SlickGrid/pull/100> with the change to changes the
behavior of the plugin.
When this PR is applied to the SlickGrid library we need to apply it to the
current version of SlickGrid that we have vendorized.
According to the libraries.txt file we are in version 2.2.4 of the library
but a diff between our code and the libraries version 2.2.4 shows
differences in the code.
Did we do any change to SlickGrid library that is vendorized? Or is just
the information in libraries.txt that is incorrect?
Does anyone know any problem if we bump the version of SlickGrid to the
newer version after the PR is applied?
Thanks
Joao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2017-04-27 03:24:22 | Re: [Design update] Style guide for pgAdmin4 |
| Previous Message | Shirley Wang | 2017-04-26 17:36:10 | Re: Declarative partitioning in pgAdmin4 |