Re: [pgAdmin4][RM#3140] Add service parameter

Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in
a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use
jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, patch applied!
>
> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> PFA updated patch.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> I'll change the name and send you updated patch.
>>>
>>>
>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> HI
>>>>
>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <
>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> PFA patch to add service parameter in server dialog.
>>>>> - Docs updated
>>>>> - Test case added for Service ID parameter
>>>>>
>>>>> Please note,
>>>>> I have extracted Connection class and Server manager class from our
>>>>> own custom Psycopg2 driver module.
>>>>>
>>>>> Patch also covers RM#3120
>>>>>
>>>>
>>>> This patch seems a little confused. The "Service" and "Service ID"
>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems
>>>> to be asking for the Service field (the pg_service.conf service name),
>>>> *not* Service ID (the operating system's service ID, used to start/stop the
>>>> database server service).
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>