Re: v3.0 release on hold

Hi Dave,
I think that this Gnome issue should be addressed after the release of 3.0.
We should create a bug and see the best way to address it after. This is my
proposal, because I am not 100% sure where this application indicator
should live.
If we search the web for application indicators we can see that usually
these are developed by 3rd parties and is are present at the applications
repository, so this might be a side project that need to be undertaken, by
someone in the community or not, but it is not something that should live
inside our repository as it is not really part of the code source and it is
more like a Hack for Gnome.

The other issues I believe need to be addressed, specially if they are
crippling to the application like when you click it does not start, but if
they are edge cases, we can always release this week and have a new release
in 2 weeks or something with more fixes to these edge case problems.

I understand that the process of release at this point is a bit cumbersome
and take a lot of time, but if we can get more tests around the new and
old feature we can have more confidence in our code and as a result of that
we can automate some of the steps in order to generate binaries more
frequently.

Thanks
Joao

On Wed, Mar 21, 2018 at 12:54 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Mar 21, 2018 at 4:22 PM, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Dave,
>> For number 1:
>> https://blogs.gnome.org/aday/2017/08/31/status-icons-and-gnome/
>> We might need to build something like:
>> https://itsfoss.com/best-indicator-applets-ubuntu/
>> Not sure if it is wise to do it in such a short notice.
>>
>
> Yeah, the problem with the suggested solutions is that they rely on 3rd
> party extensions that aren't "real" packages for the OS, so we can't just
> add a dependency on them. Unfortunately I think this is going to cause
> quite a bit of work to get 3.0 back on track.
>
>
>>
>> Thanks
>> Joao
>>
>> On Wed, Mar 21, 2018 at 11:38 AM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On 21 Mar 2018 21:05, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> We've run into a number of unexpected issues with the v3.0 release that
>>> I think we need to resolve before moving forwards. For the time being, only
>>> patches critical to fix these issues should be committed.
>>>
>>> I'll try to look at 1, though I do have another deadline I need to meet.
>>> Akshay, can you look at 2 please?
>>> Fahar is already looking at 3.
>>> Khushboo, can you look at 4 please?
>>>
>>> Sure.
>>>
>>>
>>> Thanks all.
>>>
>>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus
>>> the runtime won't initialise in Fedora 27 and later. We need an alternative
>>> for this, either a tray replacement that the RPM can depend on, or better
>>> yet, support whatever it is Gnome expect such apps to use these days.
>>>
>>> 2) Starting a second instance of the app bundle on Mac doesn't always
>>> open a new pgAdmin window as it should. It works fine in the debugger, or
>>> if you start the app with a command like: "/Applications/pgAdmin\
>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the
>>> appbundle or use a command like "open /Applications/pgAdmin\ 4.app"
>>>
>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy,
>>> but apparently his is a fresh installation.
>>>
>>> 4) On my Windows 7 machine, after running a backup I get no status
>>> window, and see the following in the logs:
>>>
>>> Traceback (most recent call last):
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi
>>> execute(self.server.app)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in execute
>>> application_iter = app(environ, start_response)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__
>>> return self.wsgi_app(environ, start_response)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app
>>> response = self.handle_exception(e)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_exception
>>> reraise(exc_type, exc_value, tb)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app
>>> response = self.full_dispatch_request()
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1614, in
>>> full_dispatch_request
>>> rv = self.handle_user_exception(e)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in
>>> handle_user_exception
>>> reraise(exc_type, exc_value, tb)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in
>>> full_dispatch_request
>>> rv = self.dispatch_request()
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in dispatch_request
>>> return self.view_functions[rule.endpoint](**req.view_args)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\venv\Lib\site-packages\flask_login.py", line 792, in decorated_view
>>> return func(*args, **kwargs)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index
>>> return make_response(response=BatchProcess.list())
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list
>>> details = desc.details(p.command, args)
>>> File "C:\Program Files (x86)\pgAdmin
>>> 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in details
>>> res += html.safe_str(cmd + self.cmd)
>>> AttributeError: 'BackupMessage' object has no attribute 'cmd'
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>