| From: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Minor JS Fix |
| Date: | 2018-05-15 13:52:36 |
| Message-ID: | CAE+jja=qOmqMJ2EGfpZ0WBFPkZYMb8Q_5WyoX7jiG60f+EMzXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
The code looks fine, all tests pass and linter.
Once again, not to sound like a broken record, we could have done some much
more to improve our code base....
Why didn't we extract that function into a more testable place?
In order for the code to become more clean and modular, we should try to
always write tests whenever we make changes to the code, even if that means
extracting a small portion (ie. the onLoad function)
Thanks
Victoria & Joao
On Tue, May 15, 2018 at 12:44 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached monir patch to fix the JS issue.
>
> Thanks,
> Khushboo
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joao De Almeida Pereira | 2018-05-15 14:05:32 | Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1 |
| Previous Message | Aditya Toshniwal | 2018-05-15 12:45:54 | Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox |