"port/atomics/arch-*.h" are missing from installation

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: "port/atomics/arch-*.h" are missing from installation
Date: 2014-10-02 14:33:36
Message-ID: CADyhKSXOdoECAaZuAOsWkeVgB604cp0ipRTVQBO_623g0z2owA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I got the following error when I try to build my extension
towards the latest master branch.

Is the "port/atomics/*.h" files forgotten on make install?

[kaigai(at)magro pg_strom]$ make
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard -g -fpic -Wall -O0
-DPGSTROM_DEBUG=1 -I. -I./ -I/usr/local/pgsql/include/server
-I/usr/local/pgsql/include/internal -D_GNU_SOURCE -c -o shmem.o
shmem.c
In file included from /usr/local/pgsql/include/server/storage/barrier.h:21:0,
from shmem.c:18:
/usr/local/pgsql/include/server/port/atomics.h:65:36: fatal error:
port/atomics/arch-x86.h: No such file or directory
# include "port/atomics/arch-x86.h"
^
compilation terminated.
make: *** [shmem.o] Error 1

Even though the source directory has header files...

[kaigai(at)magro sepgsql]$ find ./src | grep atomics
./src/include/port/atomics
./src/include/port/atomics/generic-xlc.h
./src/include/port/atomics/arch-x86.h
./src/include/port/atomics/generic-acc.h
./src/include/port/atomics/arch-ppc.h
./src/include/port/atomics/generic.h
./src/include/port/atomics/arch-hppa.h
./src/include/port/atomics/generic-msvc.h
./src/include/port/atomics/arch-ia64.h
./src/include/port/atomics/generic-sunpro.h
./src/include/port/atomics/arch-arm.h
./src/include/port/atomics/generic-gcc.h
./src/include/port/atomics/fallback.h
./src/include/port/atomics.h
./src/backend/port/atomics.c

the install destination has only atomics.h

[kaigai(at)magro sepgsql]$ find /usr/local/pgsql/include | grep atomics
/usr/local/pgsql/include/server/port/atomics.h

The attached patch is probably right remedy.

Thanks,
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>

Attachment Content-Type Size
pgsql-v9.5-fixup-makefile-for-atomics.patch application/octet-stream 537 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-10-02 14:34:57 Re: Inefficient barriers on solaris with sun cc
Previous Message Robert Haas 2014-10-02 14:28:48 Re: Per table autovacuum vacuum cost limit behaviour strange