Re: pgsql_fdw in contrib

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql_fdw in contrib
Date: 2012-07-15 20:03:37
Message-ID: CADyhKSXFtPTtgcTa_c3CCyOGYwSaeVrdypLRtCPTRpgQNkUrnw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2012/7/12 Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>:
>> 2012/6/26 Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>:
>> > Harada-san,
>> >
>> > I checked your patch, and had an impression that includes many
>> > improvements from the previous revision that I looked at the last
>> > commit fest.
>> >
>> > However, I noticed several points to be revised, or investigated.
>> >
>> > * It seems to me expected results of the regression test is not
>> > attached, even though test cases were included. Please add it.
>
> KaiGai-san, Did you find the file? That is in the contrib/pgsql_fdw/expected
> directory, named pgsql_fdw.out. If necessary, I will send the file to you.
> BTW, I found some bugs on the expected results of the file. Attached is a patch
> fixing the bugs.
>
Fujita-san,

Yes, I overlooked the expected regression test result. Probably, I forgot
to add my git repository as Hanada-san pointed out.

BTW, your patch does not make sense in my environment that is just
after initdb without any parameter customizing. Could you give us
the step to reproduce the Nested-Loop plan from Hash-Join?

Thanks,
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-07-15 20:14:41 Re: elog/ereport noreturn decoration
Previous Message Robert Haas 2012-07-15 19:36:47 Re: elog/ereport noreturn decoration