Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.

From: James Hilliard <james(dot)hilliard1(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
Date: 2020-11-20 01:02:37
Message-ID: CADvTj4ojx1wmjfc62sQPRZPqSk6Jxd5KFDft+iF_ARCcJcX6gA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I think I figured it out, it only happens on systems where the Xcode version is
newer than the OS it seems.

See:
https://forum.unity.com/threads/il2cpp-macstandalone-and-xcode-11-4.855187/

So looks like the failure happens due to the system sysroot or something like
that missing symbols from the Xcode sysroot, so I think this patch is
still correct
in that case as it forces the use of the Xcode sysroot for linking which should
be what we want as we want it to match sysroot passed to the compiler.

On Thu, Nov 19, 2020 at 5:45 PM James Hilliard
<james(dot)hilliard1(at)gmail(dot)com> wrote:
>
> On Thu, Nov 19, 2020 at 5:40 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > James Hilliard <james(dot)hilliard1(at)gmail(dot)com> writes:
> > > It would appear weak symbol linking is not handled properly without
> > > 'isysroot' parameter passed to linker.
> >
> > Nobody else has reported this problem, so maybe you should tell us
> > how to reproduce it before you suggest a build process change.
> Hmm, maybe it's a more recent issue then, I took the version number
> from the qt patch assuming it was the same issue, I hit it trying to build
> master on Xcode 12.2 Build version 12B45b on Catalina version 10.15.7.
> >
> > (And yes, we have buildfarm members testing Xcode > 11.4 ...)
> >
> > regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-11-20 01:04:49 Re: [PATCH 1/1] Fix compilation on mac with Xcode >= 11.4.
Previous Message Justin Pryzby 2020-11-20 00:51:51 Re: error_severity of brin work item