Re: ANALYZE ONLY

From: Michael Harris <harmic(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, postgres(at)jeltef(dot)nl, ilya(dot)evdokimov(at)tantorlabs(dot)com
Subject: Re: ANALYZE ONLY
Date: 2024-08-22 08:52:30
Message-ID: CADofcAWWfNTyqfzCvP8_AEDCk_h35DPMmrAXAMYLK5H1s0EbeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi All,

Here is a first draft of a patch to implement the ONLY option for
VACUUM and ANALYZE.

I'm a little nervous about the implications of changing the behaviour of VACUUM
for inheritance structures; I can imagine people having regularly
executed scripts
that currently vacuum all the tables in their inheritance structure;
after this change
they might get more vacuuming than they bargained for.

It's my first attempt to submit a patch here so apologies if I've
missed any part
of the process.

Cheers
Mike

On Thu, 22 Aug 2024 at 12:09, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 22 Aug 2024 at 13:38, Michael Harris <harmic(at)gmail(dot)com> wrote:
> > Would we want to apply that change to VACUUM too? That might be a
> > bit drastic, especially if you had a multi-level inheritance structure featuring
> > large tables.
>
> I think they'd need to work the same way as for "VACUUM (ANALYZE)", it
> would be strange to analyze some tables that you didn't vacuum. It's
> just a much bigger pill to swallow in terms of the additional effort.
>
> > It feels a bit like VACUUM and ANALYZE have opposite natural defaults here.
> > For VACUUM it does not make much sense to vacuum only at the partitioned
> > table level and not include the partitions, since it would do nothing
> > - that might
> > be why the existing code always adds the partitions.
>
> Yeah, I suspect that's exactly why it was coded that way.
>
> David

Attachment Content-Type Size
0001-Initial-implementation-of-the-ONLY-feature.patch application/octet-stream 11.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gabriele Bartolini 2024-08-22 08:58:45 Re: RFC: Additional Directory for Extensions
Previous Message Amit Kapila 2024-08-22 08:51:42 Re: Conflict detection and logging in logical replication