| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: Statistics Import and Export |
| Date: | 2025-01-21 16:21:58 |
| Message-ID: | CADkLM=fzGNLJOaYB1q=T4Q=-w+K2dqMs27tFksecqCBvJ0XTRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>
>
>
> /*
> * For indexes, we follow what do_analyze_rel() does so as to avoid any
> * deadlocks with analyze/vacuum, which is to take out a
> * ShareUpdateExclusive on table/matview first and only after that take
> * a a AccessShareLock on the index itself.
> */
> there are two "a a".
>
>
> #include "access/relation.h"
> +#include "c.h"
> +#include "catalog/pg_class_d.h"
> #include "catalog/pg_database.h"
> +#include "catalog/index.h"
> +#include "storage/lockdefs.h"
> +#include "storage/lmgr.h"
> #include "utils/acl.h"
> +#include "utils/lsyscache.h"
> #include "utils/rel.h"
> +#include "utils/syscache.h"
>
> +#include "c.h", no need. since we have "postgres.h"
> +#include "storage/lockdefs.h" no need. because #include
> "storage/lmgr.h" already have it.
> +#include "utils/syscache.h" no need. because get_rel_relkind is in
> ``#include "utils/lsyscache.h"``
>
>
> in pg_class.h we have
> #include "catalog/pg_class_d.h" /* IWYU pragma: export */
> if i read
>
> https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#iwyu-pragma-export
> correctly.
> here
> +#include "catalog/pg_class_d.h"
> should be
> +#include "catalog/pg_class.h"
>
Sorry about that, my nvim config is auto-including stuff and it's annoying.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-01-21 16:23:06 | Re: Pre-allocating WAL files |
| Previous Message | Nathan Bossart | 2025-01-21 16:13:14 | Re: Pre-allocating WAL files |