Re: Statistics Import and Export

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org
Subject: Re: Statistics Import and Export
Date: 2024-12-07 19:56:11
Message-ID: CADkLM=fyJ-Y-DNk1aW09btZYdXDXS79xT8oFPTQ6sspWHaqdog@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 7, 2024 at 2:27 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:

> On Tue, 2024-11-26 at 17:11 -0500, Corey Huinker wrote:
> >
> > > * Why does binary upgrade cause statistics to be dumped? Can you
> > > just
> > > make pg_upgrade specify the appropriate set of flags?
> > >
> >
> >
> > That decision goes back a ways, I tried to dig in the archives last
> > night but I was getting a Server Error on postgresql.org.
>
> I suggest that pg_upgrade be changed to pass --no-data to pg_dump,
> rather than --schema-only.
>
> That way, you don't need to create a special case for the pg_dump
> default that depends on whether it's a binary upgrade or not.
>

+1

> If wanted, there could also be a new option to pg_upgrade to specify --
> with-statistics (default, passes --no-data to pg_dump) or --no-
> statistics (passes --schema-only to pg_dump). But that option is
> probably not necessary; everyone upgrading probably wants the stats.
>

This makes sense, though perhaps instead of --schema-only perhaps we should
pass both --no-statistics and --no-data. I don't envision a fourth option
to the new data/schema/stats triumvirate, but --no-statistics shouldn't
have a bearing on that future fourth option.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-12-07 20:45:37 Re: meson missing test dependencies
Previous Message Paul Jungwirth 2024-12-07 19:29:33 Re: SQL:2011 application time