| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Statistics Import and Export |
| Date: | 2025-02-26 16:43:03 |
| Message-ID: | CADkLM=fdUU2s2DK6MMxkMj_XdujCopGsitTrvtyMPrcv9AUqWg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 26, 2025 at 11:23 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> > I think you had mentioned upthread something about getting rid of the
> > table-driven logic, which is fine with me. Did you mean for that to
> > happen in this patch as well?
>
> Per Corey's description of the patch (I didn't read it yet), some
> of that already happened. I want to get to buildfarm-green ASAP,
> so I'm content to leave other cosmetic changes for later.
>
The structs attarginfo and cleararginfo remain, which is notable but not
quite no-table.
> BTW, one cosmetic change that I'd like to see is that any tables that
> don't go away get marked "const". I tried to make that happen with
> attribute_stats.c's tables in my WIP patch upthread, but found that
> the need for const-ness would propagate to some utility functions and
> such, so I put the idea on the back burner.
>
I didn't even think to try const-ing those structs.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alex Friedman | 2025-02-26 16:50:40 | Re: Doc fix of aggressive vacuum threshold for multixact members storage |
| Previous Message | Tom Lane | 2025-02-26 16:23:35 | Re: Statistics Import and Export |