| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Statistics Import and Export |
| Date: | 2024-10-10 19:49:16 |
| Message-ID: | CADkLM=f_q3C9NeL9eKF8g_iCLed1K6r0Nv9Gk4Uk6i=n7fHBSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> This seems like a reasonable refactoring exercise that we could take care
> of before the rest of the patch set goes in. I added one new reference to
> dopt.schemaOnly in commit bd15b7d, so that should probably be revised to
> !dumpData, too. I also noticed a few references to dataOnly/schemaOnly in
> comments that should likely be adjusted.
>
I'll be on the lookout for the new usage with the next rebase, and will
fix the comments as well.
> One other question I had when looking at this patch is whether we could
> remove dataOnly/schemaOnly from DumpOptions and RestoreOptions. Once 0007
> is applied, those variables become particularly hazardous, so we really
> want to prevent folks from using them in new code.
Well, the very next patch in the series adds --statistics-only, so I don't
think we're getting rid of user-facing command switches. However, I could
see us taking away the dataOnly/schemaOnly internal variables, thus
preventing coders from playing with those sharp objects.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mikael Sand | 2024-10-10 19:56:41 | Re: Build issue with postgresql 17 undefined reference to `pg_encoding_to_char' and `pg_char_to_encoding' |
| Previous Message | Mikael Sand | 2024-10-10 19:08:53 | Re: Build issue with postgresql 17 undefined reference to `pg_encoding_to_char' and `pg_char_to_encoding' |