Re: Statistics Import and Export

From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org
Subject: Re: Statistics Import and Export
Date: 2024-07-22 16:05:34
Message-ID: CADkLM=f_SNcxfPC-XbwcHgCdS6FPSNo-=UZq08AWFYoBCDcxOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached is v24, incorporating Jeff's feedback - looping an arg data
structure rather than individually checking each param type being the
biggest of them.

v23's part one has been broken into three patches:

* pg_set_relation_stats
* pg_set_attribute_stats
* pg_restore_X_stats

And the two pg_dump-related patches remain unchanged.

I think this split is a net-positive for reviewability. The one drawback is
that there's a lot of redundancy in the regression tests now, much of which
can go away once we decide what other data problems we don't need to check.

>

Attachment Content-Type Size
v24-0004-Add-derivative-flags-dumpSchema-dumpData.patch text/x-patch 17.7 KB
v24-0003-Create-funcntions-pg_restore_relation_stats.patch text/x-patch 76.9 KB
v24-0002-Create-pg_set_attribute_stats-function.patch text/x-patch 96.6 KB
v24-0005-Enable-dumping-of-table-index-stats-in-pg_dump.patch text/x-patch 33.9 KB
v24-0001-Create-pg_set_relation_stats-function.patch text/x-patch 21.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-07-22 16:07:32 Re: xid_wraparound tests intermittent failure.
Previous Message Peter Geoghegan 2024-07-22 16:00:51 Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin