| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Statistics Import and Export |
| Date: | 2024-09-05 17:34:31 |
| Message-ID: | CADkLM=edhVxHr5OGZHnUeoMkjFYNpE==puOKbB1E_7j1=QsbBw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>
> git am shows some whitespace error.
>
Jeff indicated that this was more of a stylistic/clarity reworking. I'll be
handling it again for now.
>
>
> +extern Datum pg_set_relation_stats(PG_FUNCTION_ARGS);
> +extern Datum pg_set_attribute_stats(PG_FUNCTION_ARGS);
> is unnecessary?
>
They're autogenerated from pg_proc.dat. I was (pleasantly) surprised too.
> this part elevel should always be ERROR?
> if so, we can just
>
I'm personally dis-inclined to error on any of these things, so I'll be
leaving it as is. I suspect that the proper balance lies between all-ERROR
and all-WARNING, but time will tell which.
> relation_statistics_update and other functions
> may need to check relkind?
> since relpages, reltuples, relallvisible not meaning to all of relkind?
>
I'm not able to understand either of your questions, can you elaborate on
them?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-09-05 17:45:29 | Re: change regexp_substr first argument make tests more easier to understand. |
| Previous Message | Tomas Vondra | 2024-09-05 17:33:42 | Re: scalability bottlenecks with (many) partitions (and more) |