| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Catching missing Datum conversions |
| Date: | 2019-07-21 01:10:33 |
| Message-ID: | CADkLM=dkgwFrXE0wh+yeHJbpv9ZzPNmL5SSC4jbFetzrnkcS+g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> I should probably split this into "actionable" (categories 3 and 4)
> and "noise and scaffolding" patches.
>
Breaking down the noise-and-scaffolding into some subgroups might make the
rather long patches more palatable/exceedingly-obvious:
* (Datum) 0 ---> NullDatum
* 0 ----> NullDatum
* The DatumGetPointer(allParameterTypes) null tests
Having said that, everything you did seems really straightforward, except
for
src/backend/rewrite/rewriteDefine.c
src/backend/statistics/mcv.c
src/backend/tsearch/ts_parse.c
and those seem like cases where the DatumGetXXX was a no-op before Datum
was a struct.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-21 01:15:18 | Re: contrib make check-world fail if data have been modified and there's vpath |
| Previous Message | James Coleman | 2019-07-20 23:37:08 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |