| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Subject: | Re: Statistics Import and Export |
| Date: | 2024-04-03 04:59:10 |
| Message-ID: | CADkLM=diTMqw-9mgBRdHCeh1TgVLgFM4sR-b9VzO=8mDn3VWqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
v16 attached.
- both functions now use variadics for anything that can be considered a
stat.
- most consistency checks removed, null element tests remain
- functions strive to not ERROR unless absolutely necessary. The biggest
exposure is the call to array_in().
- docs have not yet been updated, pending general acceptance of the
variadic over the named arg version.
Having variant arguments is definitely a little bit more work to manage,
and the shift from ERROR to WARN removes a lot of the easy exits that it
previously had, as well as having to do some extra type checking that we
got for free with fixed arguments. Still, I don't think the readability
suffers too much, and we are now able to work for downgrades as well as
upgrades.
| Attachment | Content-Type | Size |
|---|---|---|
| v16-0001-Disable-updating-pg_class-for-CREATE-INDEX-durin.patch | text/x-patch | 900 bytes |
| v16-0002-Create-pg_set_relation_stats-pg_set_attribute_st.patch | text/x-patch | 119.7 KB |
| v16-0003-Enable-dumping-of-table-index-stats-in-pg_dump.patch | text/x-patch | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Zhilin | 2024-04-03 05:08:26 | Re: BUG: deadlock between autovacuum worker and client backend during removal of orphan temp tables with sequences |
| Previous Message | Bharath Rupireddy | 2024-04-03 04:06:33 | Re: Synchronizing slots from primary to standby |