| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Statistics Import and Export |
| Date: | 2025-02-26 21:57:34 |
| Message-ID: | CADkLM=dc_k2dKiaqDF94bP_+U403YmCYyVJ_rY+Qg9zBUHgxZg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> I have a patch that is getting thwacked around by the churn in
> stats_import.sql, and it occurred to me that I don't see why all the
> negative tests for pg_restore_relation_stats() need to have all the
> parameters provided. For example, in both of these tests, you are
> testing the relation parameter but including all these other fields.
> It's fine if there is a reason to do that, but otherwise, it makes the
> test file longer and makes the test case less clear IMO.
>
It's a known issue, and I intend to do a culling. Things have been
changing a lot with the pg_set* functions going away, and some of the tests
were covered by set* functions but not restore* functions. I'll give it a
pass once the buildfarm goes green again, and then I'm immediately shifting
gears to your patchset so that the additional tests you'll require are
smooth and minimal.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-02-26 21:58:04 | Re: Statistics Import and Export |
| Previous Message | Melanie Plageman | 2025-02-26 21:48:20 | Re: Trigger more frequent autovacuums of heavy insert tables |